fix: bump Node to 24.18.0 to resolve STS Premature close regression - #335
Merged
Conversation
Node 24.17.0 introduced an undici/http regression causing ERR_STREAM_PREMATURE_CLOSE during the GCP STS token fetch used by the E2E Workload Identity Federation flow (issue #305). The 24.16.0 pin worked around it but missed the 24.17.0 security fixes. Fixed upstream in 24.18.0 (nodejs/node#64004), which also carries the 24.17.0 security fixes. Bump both version selectors (.nvmrc and drive-scanner engines.node) past 24.17.0 to 24.18.0. Closes #305 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![kohtaka-approve-bot[bot]](https://avatars.githubusercontent.com/in/3604384?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
✅ Terraform Plan (Staging) SUCCESS📊 View full plan output in the workflow run Auto-triggered after Test workflow success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #305. Node 24.17.0 introduced an undici/http regression that broke the GCP STS token fetch in the E2E Workload Identity Federation flow, surfacing as
ERR_STREAM_PREMATURE_CLOSE(https://sts.googleapis.com/v1/token: Premature close).Background
24.16.0(38691b9) restored E2E, but 24.17.0 was a security release, so staying on 24.16.0 drops those security fixes.Changes
Bump both version selectors past 24.17.0 to 24.18.0:
.nvmrc:24.16.0→24.18.0src/functions/drive-scanner/package.jsonengines.node:24.16.0→24.18.0This resolves the STS "Premature close" failure and picks up the security fixes in one step.
Verification
npm test(all functions, including drive-scanner) passes.workflow_dispatchto confirm STS auth succeeds.Closes #305
🤖 Generated with Claude Code