Conversation
…o the Reference Knowledge.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Get the path to ReferenceKnowledge relative to this file | ||
| const currentFilePath = fileURLToPath(import.meta.url); | ||
| const projectRoot = join(dirname(currentFilePath), '..', '..'); | ||
| const toolkitSourcePath = join(projectRoot, 'ReferenceKnowledge', 'PSAppDeployToolkit_Template_v4'); |
There was a problem hiding this comment.
When outputDirectory is provided, createPackageOnDisk tries to copy the PSADT toolkit from ReferenceKnowledge/PSAppDeployToolkit_Template_v4, but this directory was deleted in this commit (ReferenceKnowledge was removed in the diff). With the path now nonexistent, the copy loops never run and the returned packageCreation still reports success, leaving the generated package without the required PSAppDeployToolkit files even though the workflow claims they were included. Any package created via package_app with --output-directory will be missing the toolkit executables/modules and won’t run.
Useful? React with 👍 / 👎.
1 participant
So much troubleshooting but I think the main hallucinations are under control. Let's give it one more round of testing in production :)