Skip to content

Update Identifier To Match Current Server API - #2

Open
madcow wants to merge 1 commit into
kjack9:mainfrom
madcow:main
Open

Update Identifier To Match Current Server API#2
madcow wants to merge 1 commit into
kjack9:mainfrom
madcow:main

Conversation

@madcow

@madcow madcow commented Feb 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Changes Proposed:

  • Rename OnLogin event handler to OnPlayerLogin to conform with current azeroth core server api.

Issues Addressed:

  • Module will not build with latest server sources.
  • Haven't opened a separate issue for this, sorry!

Tests Performed:

  • Module builds without errors.
  • Module runs the same way as before the breaking api change.

How to Test the Changes:

  1. Build module.
  2. Run module.
  3. ???
  4. Profit!

@madcow madcow changed the title Update player login event handler name for current server api Update method name to match current server api Feb 25, 2025
@madcow madcow changed the title Update method name to match current server api Update Identifier To Match Current Server API Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@madcow