favicon: improve PWA and cross-platform icon support

[Optimus-NP]

Fixes: #1189

Add proper configuration for Progressive Web App (PWA) and platform-specific icons across the application. Changes include:

• Update site.webmanifest with correct icon purposes for PWA
• Add Android Chrome icons (192x192, 512x512) to HTML
• Add Windows tile image configuration
• Ensure consistency between JS and no-JS pages

This ensures proper icon display across all platforms while following platform-specific best practices for icon implementation.

[Optimus-NP]

Hi @kelson42 @veloman-yunkan

Requesting you to review this PR.

[Optimus-NP]

Hi @rgaudin @veloman-yunkan @kelson42

Requesting you to review this PR.

[rgaudin]

Looks OK ; requested review from maintainers

[rgaudin]

I don't think it fixes said ticket though…

[Optimus-NP]

@veloman-yunkan

Please help in reviewing this PR.

[kelson42]

This does not fix #716 AFAIZk

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.45%. Comparing base (ad58a50) to head (1196a7c).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   41.45%   41.45%           
=======================================
  Files          59       59           
  Lines        4289     4289           
  Branches     2349     2349           
=======================================
  Hits         1778     1778           
  Misses        999      999           
  Partials     1512     1512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Optimus-NP]

This does not fix #716 AFAIZk

Thank you for the review. I have updated the description that it Fixes: #1189

Please take a look and merge this PR.

[rgaudin]

First item in the ticket is

Enhance favicon assets to support high-DPI screens.

There is no asset change in the PR.

I am using this PR as an opportunity to discuss kiwix-serve's Icon. It is currently using the Kiwix bird (we might want to check that it's the proper one – margin wise). While it would have already been possible for browsers (especially on mobile) to save this as an app, this new manifest makes it explicit. Is this bird-only icon what we for for a PWA of kiwix-serve? @kelson42 ?

[Optimus-NP]

@rgaudin @kelson42

I’d love to get this PR merged. Please let me know if there's anything pending on my end, I'd be happy to work on it.

[kelson42]

@Optimus-NP Thank you for your PR... and your patience. I have rebased it on the latest version of main. See please my comment on the #1189, I would like first to clarify what is not OK with the current code before assessing your PR.

[rgaudin]

@rgaudin @kelson42

I’d love to get this PR merged. Please let me know if there's anything pending on my end, I'd be happy to work on it.

Maybe answering my comment?

[kelson42]

I am using this PR as an opportunity to discuss kiwix-serve's Icon. It is currently using the Kiwix bird (we might want to check that it's the proper one – margin wise). While it would have already been possible for browsers (especially on mobile) to save this as an app, this new manifest makes it explicit. Is this bird-only icon what we for for a PWA of kiwix-serve? @kelson42 ?

@rgaudin I'm not really able to answer any of this question. To me the kiwix-serve icon is the Kiwix bird and there I have no reason (open issue) letting me think differently. Do you suggest we should run an effort around this like with did for Kiwix JS?

[rgaudin]

Indeed. This PR allows browser to consider any kiwix-serve a webapp. It is thus (as already written), an opportunity (hence no existing ticket) to question ourselves about those icons:

• Are those using the correct icons? Probably not.
• Is the bird alone appropriate for a WebApp icon? I'd say no. There's a reason this is split over a large number of files with various dimensions. We might be tempted to reuse the Kiwix desktop app icons that are probably better suited but given we have mobile readers, we don't want to create confusion between Kiwix readers and kiwix-serve instance webapps.