tagfilter: deprecate.

fuzz/fuzz_targets/all_options.rs

@@ -78,6 +78,7 @@ impl FuzzExtensionOptions {
     ) -> options::Extension<'c> {
         options::Extension {
             strikethrough: self.strikethrough,
+            #[allow(deprecated)]
             tagfilter: self.tagfilter,
             table: self.table,
             autolink: self.autolink,

fuzz/fuzz_targets/gfm.rs

@@ -2,7 +2,7 @@
 
 use libfuzzer_sys::fuzz_target;
 
-use comrak::{markdown_to_html, options, Options};
+use comrak::{Options, markdown_to_html, options};
 
 // Note that what I'm targeting here isn't exactly the same
 // as --gfm, but rather an approximation of what cmark-gfm
@@ -11,6 +11,7 @@ use comrak::{markdown_to_html, options, Options};
 fuzz_target!(|s: &str| {
     let extension = options::Extension {
         strikethrough: true,
+        #[allow(deprecated)]
         tagfilter: true,
         table: true,
         autolink: true,

fuzz/fuzz_targets/gfm_footnotes.rs

@@ -2,7 +2,7 @@
 
 use libfuzzer_sys::fuzz_target;
 
-use comrak::{markdown_to_html, options, Options};
+use comrak::{Options, markdown_to_html, options};
 
 // Note that what I'm targeting here isn't exactly the same
 // as --gfm, but rather an approximation of what cmark-gfm
@@ -11,6 +11,7 @@ use comrak::{markdown_to_html, options, Options};
 fuzz_target!(|s: &str| {
     let extension = options::Extension {
         strikethrough: true,
+        #[allow(deprecated)]
         tagfilter: true,
         table: true,
         autolink: true,

fuzz/fuzz_targets/gfm_sourcepos.rs

@@ -2,7 +2,7 @@
 
 use libfuzzer_sys::fuzz_target;
 
-use comrak::{markdown_to_html, options, Options};
+use comrak::{Options, markdown_to_html, options};
 
 // Note that what I'm targeting here isn't exactly the same
 // as --gfm, but rather an approximation of what cmark-gfm
@@ -11,6 +11,7 @@ use comrak::{markdown_to_html, options, Options};
 fuzz_target!(|s: &str| {
     let extension = options::Extension {
         strikethrough: true,
+        #[allow(deprecated)]
         tagfilter: true,
         table: true,
         autolink: true,

fuzz/fuzz_targets/quadratic.rs

@@ -1,7 +1,7 @@
 #![feature(int_roundings)]
 #![no_main]
 use comrak::{
-    markdown_to_commonmark, markdown_to_commonmark_xml, markdown_to_html, options, Options,
+    Options, markdown_to_commonmark, markdown_to_commonmark_xml, markdown_to_html, options,
 };
 use libfuzzer_sys::arbitrary::{self, Arbitrary};
 use libfuzzer_sys::fuzz_target;
@@ -207,6 +207,7 @@ impl FuzzExtensionOptions {
     fn to_options(&self) -> options::Extension<'_> {
         options::Extension {
             strikethrough: self.strikethrough,
+            #[allow(deprecated)]
             tagfilter: self.tagfilter,
             table: self.table,
             autolink: self.autolink,

src/html.rs

@@ -673,6 +673,7 @@ fn render_html_block<T>(
     if entering {
         context.cr()?;
         let literal = &nhb.literal;
+        #[allow(deprecated)]
         if context.options.render.escape {
             context.escape(literal)?;
         } else if !context.options.render.r#unsafe {
@@ -723,6 +724,7 @@ fn render_html_inline<T>(
 ) -> Result<ChildRendering, fmt::Error> {
     // No sourcepos.
     if entering {
+        #[allow(deprecated)]
         if context.options.render.escape {
             context.escape(literal)?;
         } else if !context.options.render.r#unsafe {

src/main.rs

@@ -372,6 +372,16 @@ fn main() -> Result<(), Box<dyn Error>> {
         render,
     };
 
+    if exts.contains(&Extension::Tagfilter) {
+        eprintln!(
+            "comrak: tagfilter extension deprecated (poorly designed; will be removed in Comrak 0.56.0)"
+        );
+    } else if cli.gfm {
+        eprintln!(
+            "comrak: tagfilter extension (implied by --gfm) deprecated (poorly designed; will be removed in Comrak 0.56.0)"
+        );
+    }
+
     #[cfg(feature = "syntect")]
     let syntax_highlighter: Option<&dyn SyntaxHighlighterAdapter>;
     #[cfg(feature = "syntect")]

src/parser/options.rs

@@ -57,6 +57,10 @@ pub struct Extension<'c> {
     ///            "<p>Hello &lt;xmp>.</p>\n&lt;xmp>\n");
     /// ```
     #[cfg_attr(feature = "bon", builder(default))]
+    #[deprecated(
+        since = "0.55.0",
+        note = "poorly designed; will be removed in Comrak 0.56.0"
+    )]
     pub tagfilter: bool,
 
     /// Enables the [table extension](https://github.github.com/gfm/#tables-extension-)