Skip to content

Output whitespace entities at emphasis boundaries - #750

Merged
kivikakk merged 5 commits into
mainfrom
push-ktkxttsxtyvo
Jul 6, 2026
Merged

Output whitespace entities at emphasis boundaries#750
kivikakk merged 5 commits into
mainfrom
push-ktkxttsxtyvo

Conversation

@kivikakk

@kivikakk kivikakk commented Feb 19, 2026

Copy link
Copy Markdown
Owner

Fixes #551!

@codspeed-hq

codspeed-hq Bot commented Feb 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 1 untouched benchmark


Comparing push-ktkxttsxtyvo (1fbd635) with main (5d2a755)

Open in CodSpeed

@github-actions

Copy link
Copy Markdown
Contributor
Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-02c6c19 101.8 ± 2.3 94.8 105.9 1.78 ± 0.06
./bench.sh ./comrak-main 100.6 ± 2.0 96.8 105.2 1.76 ± 0.06
./bench.sh ./pulldown-cmark 57.2 ± 1.5 54.1 61.8 1.00
./bench.sh ./cmark-gfm 87.5 ± 8.6 79.2 109.9 1.53 ± 0.16
./bench.sh ./markdown-it 252.1 ± 4.4 245.1 262.9 4.41 ± 0.14

Run on Thu Feb 19 01:37:27 UTC 2026

kivikakk added 4 commits July 6, 2026 18:15
We only need to encode the very outer characters so the run is
recognised; some of these will roundtrip differently to CommonMark but
as long as they're re-parsed the same (i.e. become the same HTML), it's
correct.
@kivikakk
kivikakk force-pushed the push-ktkxttsxtyvo branch from 9902d72 to 37a996d Compare July 6, 2026 08:29
@kivikakk
kivikakk marked this pull request as ready for review July 6, 2026 08:29
@kivikakk
kivikakk merged commit 9a3d311 into main Jul 6, 2026
51 checks passed
@kivikakk
kivikakk deleted the push-ktkxttsxtyvo branch July 6, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

**Hello ** doesn't roundtrip via CommonMark

1 participant