Skip to content

Enhance the banner block's blockWidth:noprefix schema - #910

Closed
Tishasoumya-02 wants to merge 5 commits into
mainfrom
fix-banner-block-schema
Closed

Enhance the banner block's blockWidth:noprefix schema #910
Tishasoumya-02 wants to merge 5 commits into
mainfrom
fix-banner-block-schema

Conversation

@Tishasoumya-02

Copy link
Copy Markdown
Contributor

No description provided.

@iFlameing

Copy link
Copy Markdown
Member

@danalvrz @sneridagh i want to merge this because it follow the same approach as other addons. I don't satisfied with solution but first let's merge this and then we will fix all the addons using proper fix.

https://github.com/kitconcept/volto-light-theme/blob/main/frontend/packages/volto-light-theme/src/components/Blocks/Button/schema.js#L13

https://github.com/kitconcept/volto-light-theme/blob/main/frontend/packages/volto-light-theme/src/components/Blocks/Separator/schema.js#L13

@iFlameing iFlameing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to others.

@sneridagh

Copy link
Copy Markdown
Member

We discussed and decided to go for the change in banner add-on itself. Let's fix CI there, make sure that VLT is in the env too.

@iFlameing

Copy link
Copy Markdown
Member

closing because we fix this in addon and release it also updated it here.

@iFlameing iFlameing closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants