Skip to content

chore: clear the compile warnings, and two defects release QA found - #235

Merged
kitakkun merged 3 commits into
mainfrom
chore/fix-build-warnings
Aug 6, 2026
Merged

chore: clear the compile warnings, and two defects release QA found#235
kitakkun merged 3 commits into
mainfrom
chore/fix-build-warnings

Conversation

@kitakkun

@kitakkun kitakkun commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Three commits, reviewable separately. The middle and last are not warnings — they came out of the release-readiness QA — and the last one removes a public annotation, so it leads here.

refactor! — one ExperimentalJetWhaleApi for the project

There were two, sharing a simple name, and both on a host-plugin author's classpath: jetwhale-annotations reaches jetwhale-host-sdk through jetwhale-protocol:core's api dependency. @OptIn(ExperimentalJetWhaleApi::class) therefore opted into whichever import happened to be present — silently, because both compile. They also disagreed on retention (BINARY vs RUNTIME).

Breaking: com.kitakkun.jetwhale.host.sdk.ExperimentalJetWhaleApi is gone. Import com.kitakkun.jetwhale.annotations.ExperimentalJetWhaleApi instead; it arrives transitively, so no new dependency. The surviving definition is the host-sdk one's — BINARY retention, an explicit message, narrowed targets — moved to the shared module.

The internal pair was disambiguated long ago as InternalJetWhaleApi / InternalJetWhaleHostApi. The experimental pair never was. Cheap now, expensive after 1.0.

fix — the Apple discovery results were raced

HostDiscovery.apple.kt appended to a plain MutableList from the main run loop while reading it from whatever thread the coroutine resumed on once the timeout expired — and the browser is still live at that moment, since cancellation only dispatches the stop to the main queue. Android's actual has used a synchronized list for exactly this all along.

An AtomicReference rather than a lock: appends come from the main queue alone, so there is a single writer and read-then-store needs no CAS loop. Only the visibility was missing.

chore — the warnings
OkHttp Response.body non-null; four ?. in the demo, three !! in the interceptor tests
McpJsonSchema three per-declaration opt-ins that still left two sites uncovered → one file-level
NsdServiceInfo.host deprecated by API 34 in favour of hostAddresses, minSdk is 23 → chosen at runtime. Taking the first of the list is what host documented itself to return, so the branches agree rather than merely both compiling
TabRow / ScrollableTabRow → the Secondary* variants, which keep the full-width indicator. Primary* would also have restyled the tabs
MenuAnchorType → ExposedDropdownMenuAnchorType, matching what SessionSelectorView already used
compose.desktop.<platform> written out. The coordinates are exactly what those accessors resolved to — checked by resolving all four configurations before and after
js(IR), Configuration.isVisible, @Inject placement mechanical
-Xexpect-actual-classes on test-annotations alone, the one module declaring an expect/actual annotation. KT-61573 asks you to acknowledge Beta; this is not a way of hiding it

Deliberately left: LocalClipboardManager

Compose Multiplatform 1.11.1 offers no plain-text helper on the replacement — migrating means writing AWT StringSelection handling into four Compose screens, against an API whose own shape is still moving. Not a trade worth making in a release window for a deprecation that works.

Verification

./gradlew spotlessCheck check — BUILD SUCCESSFUL, 0 errors. Judged from the build log rather than the exit code; an earlier run reported success while the log said otherwise.

Two mistakes of mine that the build caught, recorded because they shaped the diff:

  • A recovery step left the deleted host.sdk annotation back on disk while the commit claimed to remove it. checkKotlinAbi failed on the mismatch.
  • jetwhale-host/core/mcp/build.gradle.kts opted in by the removed FQN, so deleting the annotation silently disabled the opt-in and produced 164 warnings in that module. I first measured this as pre-existing — the comparison was taken against a tree that already had the deletion committed, so it was no baseline at all. Re-measured against the module directly: 164 → 0 once the FQN was updated.

Warning sweep caveat: the final run was largely incremental, so cached compilations contributed no warnings. The known remainder is the three clipboard sites above.

kitakkun added 3 commits August 6, 2026 23:07
@kitakkun
chore: clear the compile warnings
df1a8e1 
Nothing here changes behaviour; each is a warning the build has been carrying.

Redundant null handling on OkHttp's `Response.body`, which is non-null — four
safe calls in the demo, three `!!` in the interceptor tests.

`McpJsonSchema` had three per-declaration `@OptIn(ExperimentalSerializationApi)`
that still left two sites uncovered; one file-level opt-in covers the file, which
is what it always meant.

`NsdServiceInfo.host` was deprecated by API 34 in favour of `hostAddresses`, and
minSdk here is 23, so the two are chosen between at runtime. Taking the first of
the list matches what `host` documented itself to return, so the branches agree
rather than merely both compiling.

Compose deprecations: `TabRow` and `ScrollableTabRow` become the `Secondary*`
variants — those keep the full-width indicator, so this is a rename and not a
restyle, where `Primary*` would also change how the tabs look. `MenuAnchorType`
becomes `ExposedDropdownMenuAnchorType`, matching what SessionSelectorView
already used.

`compose.desktop.<platform>` accessors were deprecated in favour of naming the
dependency. The coordinates written out are exactly what those accessors resolved
to, checked by resolving each of the four configurations before and after.

`js(IR)` loses its argument (IR is the only compiler), `Configuration.isVisible`
goes, `@Inject` moves to the class where it is the only annotated constructor,
and test-annotations opts into `-Xexpect-actual-classes` — it is the one module
declaring an expect/actual annotation, and the flag is how KT-61573 asks you to
acknowledge Beta rather than a way of hiding it.

`LocalClipboardManager` is deliberately left. Compose Multiplatform 1.11.1 offers
no plain-text helper on the replacement, so migrating means writing AWT
`StringSelection` handling into four Compose screens against an API whose own
shape is still moving — not a trade worth making in a release window for a
deprecation that works.
@kitakkun
fix(agent-runtime): stop racing on the Apple discovery results
892f280 
The delegate appends to the results list from the main run loop, while the read
at the end of the browse happens on whatever thread the coroutine resumed on once
the timeout expired — and the browser is still live at that moment, because
cancellation only *dispatches* the stop to the main queue. Nothing ordered the
two. Android's actual has used a synchronized list for this all along.

An AtomicReference rather than a lock: appends come from the main queue alone, so
there is a single writer and read-then-store needs no CAS loop. Only the
visibility is missing, and that is what the atomic supplies.
@kitakkun
refactor!: keep one ExperimentalJetWhaleApi for the whole project
ef035d7 
There were two, sharing a simple name and both on a host-plugin author's
classpath — `jetwhale-annotations` reaches host-sdk through
`jetwhale-protocol:core`'s api dependency. `@OptIn(ExperimentalJetWhaleApi::class)`
therefore opted into whichever import happened to be present, silently, since
both compile. They also disagreed on retention.

The host-sdk copy is removed and its better-specified definition — BINARY
retention, an explicit message, narrowed targets — is what the shared one now
carries. The internal pair was disambiguated long ago as `InternalJetWhaleApi`
and `InternalJetWhaleHostApi`; the experimental pair never was.

BREAKING: `com.kitakkun.jetwhale.host.sdk.ExperimentalJetWhaleApi` is gone.
Host-plugin authors opting in by that name should import
`com.kitakkun.jetwhale.annotations.ExperimentalJetWhaleApi` instead, which
arrives transitively and needs no new dependency. Cheap now, expensive after 1.0.
Copilot AI lite review requested due to automatic review settings August 6, 2026 14:07
Copilot AI reviewed Aug 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates the project’s experimental opt-in annotation into a single shared definition (jetwhale-annotations) to prevent ambiguous opt-ins for plugin authors, fixes a real concurrency defect in Apple host discovery, and performs a repo-wide warning sweep (Compose/Gradle/KMP/OkHttp/deprecation cleanups).

Changes:

  • Remove com.kitakkun.jetwhale.host.sdk.ExperimentalJetWhaleApi and migrate usages to com.kitakkun.jetwhale.annotations.ExperimentalJetWhaleApi.
  • Fix a data race in Apple mDNS discovery result collection; update Android discovery to handle API 34’s hostAddresses.
  • Mechanical warning fixes across build scripts and UI code (KMP js(IR) deprecation, Material3 Secondary*TabRow, ExposedDropdownMenuAnchorType, etc.).

Reviewed changes

Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test-annotations/build.gradle.kts Adds module-scoped -Xexpect-actual-classes compiler flag for the expect/actual annotation use case.
jetwhale-plugins/semantics/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/semantics/host/PerformNodeActionCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/semantics/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/semantics/host/GetNodeTreeCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/semantics/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/semantics/host/FindNodesCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/semantics/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/semantics/host/ComposeSemanticsInspectorPluginFactory.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/semantics/agent/build.gradle.kts Migrates deprecated js(IR) DSL usage to js { ... }.
jetwhale-plugins/network/host/src/test/kotlin/com/kitakkun/jetwhale/plugins/network/host/NetworkMcpCommandsTest.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/test/kotlin/com/kitakkun/jetwhale/plugins/network/host/McpParameterDslTest.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/TrafficView.kt Replaces deprecated TabRow with SecondaryTabRow to match updated Material3 APIs.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/SetMockRulesCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/SetMockingEnabledCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/RemoveMockRuleCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/NetworkInspectorScreen.kt Replaces deprecated TabRow with SecondaryTabRow.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/NetworkHostPluginFactory.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/MocksView.kt Updates deprecated MenuAnchorType to ExposedDropdownMenuAnchorType.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/ListTransactionsCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/GetTransactionCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/GetMockConfigCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/ClearTransactionsCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/network/host/AddMockRuleCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/network/agent-okhttp/src/test/kotlin/com/kitakkun/jetwhale/plugins/network/agent/okhttp/JetWhaleNetworkOkHttpInterceptorTest.kt Removes unnecessary null-assertions on OkHttp Response.body (now non-null in the used API).
jetwhale-plugins/nav3/host/src/test/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/Nav3McpCommandsTest.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/ReplaceBackStackCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/RemoveNavKeyCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/PushNavKeyCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/PopBackStackCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/Nav3NavigatorScreen.kt Replaces deprecated ScrollableTabRow with SecondaryScrollableTabRow.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/Nav3HostPluginFactory.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/Nav3BackStackController.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/MoveNavKeyToTopCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/ListNavKeyTypesCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/nav3/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/nav3/host/GetBackStackCommand.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/example/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/example/host/ExampleHostPluginFactory.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-plugins/example/host/src/main/kotlin/com/kitakkun/jetwhale/plugins/example/host/ExampleHeadlessPluginFactory.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-host/feature/settings/src/main/kotlin/com/kitakkun/jetwhale/host/settings/plugin/MavenPluginInstallDialog.kt Updates deprecated MenuAnchorType to ExposedDropdownMenuAnchorType.
jetwhale-host/core/mcp/src/test/kotlin/com/kitakkun/jetwhale/host/mcp/McpToolRegistryTest.kt Updates opt-in annotation import to the shared jetwhale-annotations FQN.
jetwhale-host/core/mcp/build.gradle.kts Updates module-wide opt-in compiler arg to the new annotation FQN.
jetwhale-host/core/data/src/main/kotlin/com/kitakkun/jetwhale/host/data/plugin/DefaultPluginFactoryRepository.kt Adjusts Metro @Inject placement to match the project’s injection style.
jetwhale-host/app/src/main/kotlin/com/kitakkun/jetwhale/host/drawer/McpToolsScreen.kt Replaces deprecated TabRow with SecondaryTabRow.
jetwhale-host/app/build.gradle.kts Writes out Compose Desktop dependency coordinates instead of deprecated compose.desktop.<platform> accessors.
jetwhale-host-sdk/src/test/kotlin/com/kitakkun/jetwhale/host/sdk/McpJsonSchemaTest.kt Consolidates opt-ins via file-level @OptIn, including the moved experimental annotation.
jetwhale-host-sdk/src/main/kotlin/com/kitakkun/jetwhale/host/sdk/McpJsonSchema.kt Moves repeated @OptIn(ExperimentalSerializationApi) to a file-level opt-in.
jetwhale-host-sdk/src/main/kotlin/com/kitakkun/jetwhale/host/sdk/JetWhaleMcpCommand.kt Imports and applies the shared @ExperimentalJetWhaleApi to the MCP command surface.
jetwhale-host-sdk/src/main/kotlin/com/kitakkun/jetwhale/host/sdk/JetWhaleMcpCapablePlugin.kt Imports and applies the shared @ExperimentalJetWhaleApi to plugin-facing MCP types.
jetwhale-host-sdk/src/main/kotlin/com/kitakkun/jetwhale/host/sdk/DefaultArgumentJson.kt Imports the shared experimental annotation (supporting the unified opt-in model).
jetwhale-host-sdk/src/main/kotlin/com/kitakkun/jetwhale/host/sdk/ExperimentalJetWhaleApi.kt Removes the host-sdk-local public experimental annotation (breaking change per PR description).
jetwhale-host-sdk/api/jetwhale-host-sdk.api Updates ABI surface to reflect removal of the host-sdk annotation type.
jetwhale-gradle-plugin/src/main/kotlin/com.kitakkun.jetwhale.host.gradle.kts Removes deprecated Configuration.isVisible assignment.
jetwhale-annotations/src/commonMain/kotlin/com/kitakkun/jetwhale/annotations/ExperimentalJetWhaleApi.kt Becomes the single project-wide definition of ExperimentalJetWhaleApi (message/targets/retention).
jetwhale-agent-runtime/src/jvmTest/kotlin/com/kitakkun/jetwhale/agent/runtime/MessagingServiceResolutionTest.kt Adds file-level opt-in to silence experimental coroutines API warnings in tests.
jetwhale-agent-runtime/src/appleMain/kotlin/com/kitakkun/jetwhale/agent/runtime/HostDiscovery.apple.kt Fixes discovery result collection race by using an AtomicReference to an immutable list.
jetwhale-agent-runtime/src/androidMain/kotlin/com/kitakkun/jetwhale/agent/runtime/HostDiscovery.android.kt Uses hostAddresses on API 34+ while retaining deprecated host below 34 with suppression.
gradle-conventions/src/main/kotlin/multiplatform.gradle.kts Migrates deprecated js(IR) DSL usage to js { ... } in shared conventions.
demo/web/build.gradle.kts Migrates deprecated js(IR) DSL usage to js { ... }.
demo/shared/src/commonMain/kotlin/com/kitakkun/jetwhale/demo/shared/App.kt Replaces deprecated TabRow with SecondaryTabRow.
demo/shared/src/androidMain/kotlin/com/kitakkun/jetwhale/demo/shared/PlatformExtraTab.android.kt Removes unnecessary safe-calls on OkHttp Response.body in demo networking.
demo/shared/build.gradle.kts Migrates deprecated js(IR) DSL usage to js { ... }.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kitakkun
kitakkun merged commit eef6fed into main Aug 6, 2026
5 checks passed
@kitakkun
kitakkun deleted the chore/fix-build-warnings branch August 6, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kitakkun