fix(checkout): inherit variant shipping data - #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Variable products can leave weight and dimensions empty on the variation while configuring those values on the parent product. Product readiness already treats this setup as configured, but
GetWCCartAttributeServiceloaded only variation metadata. The resulting/shipping_pricepayload contained zero weight or dimensions, preventing shipping rates from appearing.Root cause
The cart attribute resolver selected
variation_idas the sole metadata source. Unlike the product readiness checks, it never retainedproduct_idor applied field-level parent fallback. Empty variation dimensions were therefore discarded by volumetric calculation, and empty variation weight remained zero.Solution
_weight,_length,_width, and_heightindependentlyThe shared cart attribute service feeds the shipping method, checkout calculation, and ongkir pricing flows, so all storefront
shipping_pricecalls receive the corrected payload.Verification
make test: 439 tests passedmake zip: package/source parity passedgit diff --check: passed