fix: reanimated 3.0 compatibility - #1596
Merged
Merged
Conversation
Owner
Author
|
Hey @ahulterstrom 👋 Could you please confirm that these changes fix a problem 2 described in #1585 (comment)? 🙏 |
Contributor
📊 Package size report
|
kirillzyusko
marked this pull request as ready for review
August 11, 2026 08:25
Contributor
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed package compatibility for reanimated version lower than 3.7.0
💡 Motivation and Context
On Reanimated
3.7.0-theuseEventhandler returnsref(withcurrentproperty). After reanimated 3.8.0 it returns an object that containsworkletEventHandler. Somehow in #1209 I thought that it returns the event handler directly (not in ref). So I declared the object as object-or-direct-handler.In #1585 (comment) I realized that I made a mistake, so in this PR I eliminated a dead code and fixed compatibility.
Follow up for #1209 (something that had to be implemented there from the beginning).
Closes #1585 (comment)
📢 Changelog
JS
WorkletHandlerOrWorkletHandlerObjecttoWorkletHandlerContainer;currentHandler.*withcurrentHandler.current.*;🤔 How Has This Been Tested?
Tested via this PR (e2e tests).
📸 Screenshots (if appropriate):
📝 Checklist