fix: codegen import to ensure better compatibility with older RN versions - #1595
Merged
Conversation
Contributor
📊 Package size report
|
kirillzyusko
marked this pull request as ready for review
August 10, 2026 09:55
Contributor
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Use old import of
codegenNativeComponentfromreact-native/Libraries/Utilities/codegenNativeComponent"instead ofreact-native(becausereact-nativeimport was added relatively recently).💡 Motivation and Context
This matches the whole setup of all components included in this package. At sme point we will switch to
react-nativeimport, but in this case we'll drop minimal supported RN version and it needs to be reflected in documentation. For now just use old approach that gives a wider compatibility.Closes #1585 (comment)
📢 Changelog
JS
codegenNativeComponentfromreact-native/Libraries/Utilities/codegenNativeComponent";🤔 How Has This Been Tested?
Tested via this PR.
📸 Screenshots (if appropriate):
📝 Checklist