fix: remove java-package prefix from ClippingScrollViewDecoratorViewManager class to avoid compilation errors - #1587
Merged
kirillzyusko merged 1 commit intoAug 8, 2026
Conversation
…ewManager` class to avoid compilation errors
kirillzyusko
added
🤖 android
Contributor
📊 Package size report
|
kirillzyusko
marked this pull request as ready for review
August 7, 2026 14:29
Contributor
|
LGTM |
kirillzyusko
deleted the
fix/java-prefix-for-clipping-scroll-view-causes-compilation-errors
branch
August 8, 2026 04:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix compilation for RN < 0.74 and library version 1.21.x 🤞
💡 Motivation and Context
I think at early prototype stage I created file in Android Studio and it automatically added
javaprefix and additional import inbasepackage.I didn't notice it until #1585 has been raised. In fact we don't need that
javaprefix (see how other managers are organized). So in this PR I removed unnecessaryjavaprefix + removed unnecessary import in base package 🤞 It should fix compilation error on old RN versions that are usingturbo-package variant.Closes #1585
📢 Changelog
Android
javafromClippingScrollViewDecoratorManagerinpackagedeclaration;java.com.reactnativekeyboardcontroller.ClippingScrollViewDecoratorViewManagerimport in base package.🤔 How Has This Been Tested?
Tested via this PR. If something would be broken CI would fail for this PR too.
📸 Screenshots (if appropriate):
📝 Checklist