fix: KeyboardChatScrollView crash on unmount - #1579
Merged
Merged
Conversation
kirillzyusko
added
🎯 crash
Contributor
📊 Package size report
|
…d in multiple components and we have edge cases which needs to be carefully checked manually every time
kirillzyusko
marked this pull request as ready for review
August 3, 2026 12:23
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed a crash when cleaning up handlers for unmounted view.
💡 Motivation and Context
The regression has been introduced in #1209
Before we were storing an arrays of
ids. In new PR we started to retrieve view id on demand (when it's unmounted). But when view is getting unmounted, then we may not be able to retrieve its data which will lead to the crash.So in this PR I partially restore the old behavior - we also store the data in closure (variable defined outside of function). It fixes a crash. I also added unit tests to avoid problems in the future.
Closes #1577
📢 Changelog
JS
viewTagand callfindNodeHandlein cleanup effect;🤔 How Has This Been Tested?
Tested via e2e tests.
📸 Screenshots (if appropriate):
N/A
📝 Checklist