Skip to content

fix: defer focused input layout sync out of synchronous onStart dispatch #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirillzyusko merged 2 commits into from
Aug 3, 2026
Merged

fix: defer focused input layout sync out of synchronous onStart dispatch #1576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f831f6
fix: defer focused input layout sync out of synchronous onStart dispatch
AhmedAlAmawi Aug 2, 2026
07e6752
refactor: move layout sync into onKeyboardResized, remove verbose com…
AhmedAlAmawi Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...id/src/main/java/com/reactnativekeyboardcontroller/listeners/KeyboardAnimationCallback.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ class KeyboardAnimationCallback(

if (isKeyboardFullyVisible && !isKeyboardSizeEqual && !isResizeHandledInCallbackMethods) {
Logger.i(TAG, "onApplyWindowInsets: ${this.persistentKeyboardHeight} -> $keyboardHeight")
layoutObserver?.syncUpLayout()
this.onKeyboardResized(keyboardHeight)

return insets
Expand Down Expand Up @@ -217,8 +216,6 @@ class KeyboardAnimationCallback(
this.persistentKeyboardHeight = keyboardHeight
}

layoutObserver?.syncUpLayout()

// keyboard gets resized - we do not want to have a default animated transition
// so we skip these animations
val isKeyboardResized = keyboardHeight != 0.0 && prevKeyboardHeight != keyboardHeight
Expand Down Expand Up @@ -427,6 +424,8 @@ class KeyboardAnimationCallback(
private fun onKeyboardResized(keyboardHeight: Double) {
duration = 0

layoutObserver?.syncUpLayout()

context.emitEvent("KeyboardController::keyboardWillShow", getEventParams(keyboardHeight))
listOf(
KeyboardTransitionEvent.Start,
Expand Down Expand Up @@ -477,6 +476,7 @@ class KeyboardAnimationCallback(
val event = pendingStartEvent ?: return

pendingStartEvent = null
layoutObserver?.syncUpLayout()
context.dispatchEvent(
eventPropagationView.id,
KeyboardTransitionEvent(
Expand Down
Loading