fix: use propagation view surfaceId for focused input events inside Modal - #1570
Merged
kirillzyusko merged 2 commits intoAug 5, 2026
Merged
Conversation
kirillzyusko
reviewed
Aug 5, 2026
kirillzyusko
left a comment
Owner
There was a problem hiding this comment.
Thank you for PR! Once you address comments we can merge it 🙌
Contributor
📊 Package size report
|
- Keep the propagation surface ID implementation private\n- Remove the over-engineered observer unit test
surfaceId for focused input events inside Modal
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Resolve Android focused-input event surface IDs from the React event propagation view instead of the watched modal window root.
💡 Motivation and Context
ModalAttachedWatcherobserves the modal window root while dispatching focused-input events through a separate React view. Resolving the surface ID from the window root returns-1under Fabric, producing a surface/target mismatch for layout, text, and selection events.The non-modal path is unchanged because both constructor arguments reference the same React view.
Fixes #1569.
📢 Changelog
Android
🤔 How Has This Been Tested?
📝 Checklist