Skip to content

fix: tolerate fractional iOS keyboard positions #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarshallBear1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: tolerate fractional iOS keyboard positions #1545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ios/observers/movement/KeyboardTrackingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,17 @@ public final class KeyboardTrackingView: UIView {

// for `keyboardLayoutGuide` case we can just read keyboard position directly - no interpolation needed
if KeyboardControllerConfiguration.usesKeyboardLayoutGuideTracking {
if keyboardPosition > keyboardHeight {
// when we are the top position KVO takes `inputAccessoryView` into consideration,
// so we handle it here. KVO reports coordinates on the screen's pixel
// grid, while `keyboardHeight` can include a fractional accessory-view
// offset (for example, a hairline border). Treat values within one pixel
// as the same fully-open position instead of relying on exact equality.
let screenScale = trackedView.window?.screen.scale ?? UIScreen.main.scale
let positionTolerance = 1 / max(screenScale, 1)
if keyboardPosition > keyboardHeight + positionTolerance {
return Self.invalidPosition
}
// when we are the top position KVO takes `inputAccessoryView` into consideration,
// so we handle it here
if keyboardPosition == keyboardHeight {
if abs(keyboardPosition - keyboardHeight) <= positionTolerance {
return keyboardPosition - KeyboardAreaExtender.shared.offset
}
return keyboardPosition
Expand Down
Loading