Skip to content

fix: remove unnecessary code #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirillzyusko merged 1 commit into from
Mar 23, 2026
Merged

fix: remove unnecessary code #1389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/components/KeyboardAwareScrollView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,14 +552,8 @@ const KeyboardAwareScrollView = forwardRef<
[],
);

// animations become choppy when scrolling to the end of the `ScrollView` (when the last input is focused)
// this happens because the layout recalculates on every frame. To avoid this we slightly increase padding
// by `+1`. In this way we assure, that `scrollTo` will never scroll to the end, because it uses interpolation
// from 0 to `keyboardHeight`, and here our padding is `keyboardHeight + 1`. It allows us not to re-run layout
// re-calculation on every animation frame and it helps to achieve smooth animation.
// see: https://github.com/kirillzyusko/react-native-keyboard-controller/pull/342
const padding = useDerivedValue(
() => (enabled ? currentKeyboardFrameHeight.value + 1 : 0),
() => (enabled ? currentKeyboardFrameHeight.value : 0),
[enabled],
);

Expand Down
Loading