Add BetterMace Fabric mod for Minecraft 1.21.4#2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Add BetterMace Fabric mod for Minecraft 1.21.4#2devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Adds a Fabric mod under minecraft-mods/bettermace that improves the vanilla Mace by: - Applying AOE damage on a smash attack scaled by fall distance - Pushing nearby targets outward + smash particles/sound - Optional lightning bolt on extreme falls (cosmetic by default) - Optional self-bounce for the attacking player (Wind-Burst-style) - All values are configurable via config/bettermace.json Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a self-contained Fabric mod under
minecraft-mods/bettermace/that improves the vanilla Mace weapon in Minecraft 1.21.4. This is a new top-level subdirectory in the repo and does not touch any existing DeepSeek-Math code.What the mod does (all toggleable / tuneable via
config/bettermace.json):LivingEntitys around the primary target also take a fraction of the fall-distance bonus damage and get knocked outward. Radius scales with fall distance up to a cap.MACE_SMASH_GROUND_HEAVY+SWEEP_ATTACKparticles for the AOE.Implementation: a single mixin (
MaceItemMixin)@Injects at HEAD ofnet.minecraft.item.MaceItem#postHurtEnemy. Config is a simple GSON-serialized POJO inFabricLoader.getConfigDir()/bettermace.json, auto-created on first load.Files added (all new, under
minecraft-mods/bettermace/):build.gradle,settings.gradle,gradle.properties,gradle/wrapper/gradle-wrapper.properties,.gitignoresrc/main/resources/fabric.mod.json,bettermace.mixins.jsonsrc/main/java/dev/bettermace/BetterMace.java(entrypoint)src/main/java/dev/bettermace/config/BetterMaceConfig.javasrc/main/java/dev/bettermace/mixin/MaceItemMixin.javaREADME.md(RU)Review & Testing Checklist for Human
This PR was not built or run locally — there is no JDK 21 / fabric-loom toolchain in the session, and the Minecraft/Yarn/Fabric-API artifacts were not fetched. Treat every interaction with Minecraft internals below as unverified.
./gradlew buildlocally with JDK 21. Note: onlygradle-wrapper.propertieswas committed —gradle-wrapper.jar,gradlew, andgradlew.batare not in the repo, so you'll need to rungradle wrapperonce (with a system Gradle 8.10.2) to generate them before./gradlew buildwill work. Consider whether you want those wrapper files committed.postHurtEnemyactually exists onnet.minecraft.item.MaceItemat yarn1.21.4+build.8. The method was renamed frompostHitsomewhere in the 1.21.x line; if 1.21.4 yarn still uses a different name (or the mapping build number doesn't exist), the mixin will hard-fail at load (defaultRequire: 1). Pinned versions ingradle.properties:yarn=1.21.4+build.8,loader=0.16.9,fabric_api=0.114.0+1.21.4,loom=1.9-SNAPSHOT— please confirm these resolve.LivingEntity#damage(ServerWorld, DamageSource, float),EntityType#create(ServerWorld, SpawnReason),LightningEntity#setCosmetic / setChanneler / refreshPositionAfterTeleport,Entity#velocityModifiedfield,ServerWorld#getEntitiesByClass. If any of these were renamed in 1.21.4 yarn, the mixin won't compile.kinngg2/DeepSeek-Math— this repo is a Python ML research project; a Minecraft mod is a topical mismatch. If you wanted it in a different repo, say the word and I'll move it.Notes
4/2/1per block for0–3 / 3–8 / 8+) is a reconstruction of vanilla, not a re-use ofMaceItem.getBonusAttackDamage. If vanilla's exact thresholds differ in 1.21.4, the AOE damage numbers will drift slightly from "ideal."MaceItemMixin.javahas an unusedimport net.minecraft.entity.Entity;— harmless warning, easy follow-up cleanup.LICENSEfile is present in the mod subdirectory, butbuild.gradlereferences one injar { from("LICENSE") ... }— thefromwill silently no-op if the file is absent, but you may want to add one or remove that block.Link to Devin session: https://app.devin.ai/sessions/fa8c614cc631433a9d395c4426214190
Requested by: @kinngg2