Add option to specify stream formats when searching, search all forma…#52
Open
olszewst wants to merge 1 commit into
Open
Add option to specify stream formats when searching, search all forma…#52olszewst wants to merge 1 commit into
olszewst wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TuneIn search API accepts an argument called
formatswhere caller can specify what stream formats it supports. If a stream is not available in any of the requested formats, API call only does not return such stream (the response only contains a placeholder that says "Unsupported stream format").This PR adds an option to explicitly specify what formats should be included in the response. It also changes the default behavior: queries will now by default request all formats (
formats=*) instead of leaving this option blank that yields only streams in formats that TuneIn picked as default.I believe this PR should fix #50, but I didn't verify this. It did help me another stream that I had exactly the same problem with.