test(int-factor): complete Phase 3 conformance - #9882
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9627.
Summary
Phase provenance
The bridge SPEC is newly authored here to make the already-landed correspondence surface and runtime boundary explicit; the counters were lagging existing implementation. A fresh isolated Claude Opus reviewer independently checked that SPEC against the source, transported Mathlib APIs, downstream needs, Phase contracts, and this PR diff. It found no blocker. Its four actionable observations were all addressed: document
factorization_absent, clarify the attestation provenance, externally cross-check the ascending divisor enumeration, and add actual prime-table boundary cases.Verification
python3 -m unittest scripts.test_check_dagpython3 scripts/check_dag.pylake build HexIntFactor HexIntFactorMathlib HexConformancehexintfactor_emit_fixturesoutput matches the committed JSONL byte-for-bytepython3 -m py_compile scripts/oracle/intfactor_pari.pyThe required PARI/python-flint oracle remains wired in the existing single CI job. Local fixture regeneration succeeded; CI supplies the unavailable local
cypari2dependency and performs the required oracle run.