Forecast symbols v1 - #371
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the forecast retrieval to include GeoSphere’s forecast symbol parameter (sy) in the default forecast parameter set, aligning the client output with the intent to expose forecast symbols (not just cloud coverage).
Changes:
- Add
syto the default parameter list returned byget_forecast_current(). - Add
syto the defaultget_forecast()request parameter string. - Update forecast-related test fixtures to include
sydata.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/zamg/zamg.py |
Adds sy to default forecast request/selection parameters so forecast symbol values are returned. |
tests/test_zamg.py |
Extends mocked forecast payloads to include sy values. |
src/zamg/__init__.py |
Bumps __version__ (used in the User-Agent). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now returns forecast symbols instead of only the cloud coverage.