Skip to content

Forecast symbols v1 - #371

Merged
killer0071234 merged 4 commits into
mainfrom
forecast-symbols-v1
Jul 20, 2026
Merged

Forecast symbols v1#371
killer0071234 merged 4 commits into
mainfrom
forecast-symbols-v1

Conversation

@killer0071234

Copy link
Copy Markdown
Owner

Now returns forecast symbols instead of only the cloud coverage.

Copilot AI review requested due to automatic review settings July 20, 2026 12:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the forecast retrieval to include GeoSphere’s forecast symbol parameter (sy) in the default forecast parameter set, aligning the client output with the intent to expose forecast symbols (not just cloud coverage).

Changes:

  • Add sy to the default parameter list returned by get_forecast_current().
  • Add sy to the default get_forecast() request parameter string.
  • Update forecast-related test fixtures to include sy data.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/zamg/zamg.py Adds sy to default forecast request/selection parameters so forecast symbol values are returned.
tests/test_zamg.py Extends mocked forecast payloads to include sy values.
src/zamg/__init__.py Bumps __version__ (used in the User-Agent).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_zamg.py
Comment thread tests/test_zamg.py
Comment thread src/zamg/__init__.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread src/zamg/zamg.py
@killer0071234
killer0071234 merged commit 28d606a into main Jul 20, 2026
1 check passed
@killer0071234
killer0071234 deleted the forecast-symbols-v1 branch July 20, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants