Pass history event's isNavigation attribute to dispatch-fn - #38
Open
nathell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Daniel from WorksHub here. First, let me express our gratitude for pushy – it powers navigation in our app and is an excellent little piece of software. Many thanks!
We found ourselves needing to determine in our dispatch-fn whether the request comes from a user's on-page action (clicking a link handled by pushy), or from a browser history action (e.g., clicking Back). Turns out that it's hidden in the
isNavigationproperty of the Closure Library'sNAVIGATEevent. This PR passes the value of that property as a second argument to dispatch-fn.Technically, it's an API breaking change (since dispatch-fn is now expected to take two arguments, rather than one), but I don't have a good idea of how to make it more kosher. I'd be happy to discuss this further.