fix: preserve editor route on reload#19
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e53a8b096f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| showEditorShell(); | ||
|
|
||
| if (draftBootstrapPromise) { | ||
| await draftBootstrapPromise; |
There was a problem hiding this comment.
When IndexedDB is slow (for example with an image-heavy saved board) and the user opens #editor on reload or clicks Go immediately after page load, this shows the editor before draftBootstrapPromise resolves. The toolbar is usable during that window, but any objects the user adds can then be replaced by canvas.loadFromJSON() when the old draft restore finishes, and those early edits are not autosaved because draftBootstrapComplete is still false.
Useful? React with 👍 / 👎.
Co-authored-by: OpenAI Codex <codex@openai.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
#editorin the editor instead of briefly showing the landing view.Validation
pnpm run preflightapp.jsfirst-paint check, normal#editorreload with restored text, editor home route clearCo-authored-by: Codex codex@openai.com