fix(pdf): don't reopen NamedTemporaryFile while it's still held open - #1393
Open
MsfPablo wants to merge 1 commit into
Open
fix(pdf): don't reopen NamedTemporaryFile while it's still held open#1393MsfPablo wants to merge 1 commit into
MsfPablo wants to merge 1 commit into
Conversation
On Windows, PyMuPDFLoader cannot open a NamedTemporaryFile's path while the file handle from tempfile.NamedTemporaryFile(delete=True) is still open, causing PermissionError: [WinError 32] and silently skipping all PDF indexing. Use delete=False, close the handle before handing the path to PyMuPDFLoader, and clean up the temp file ourselves in a finally block. Fixes khoj-ai#1368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1368. On Windows,
PdfToEntries.extract_textfails to index any PDF becausePyMuPDFLoaderis passed the path of a still-openNamedTemporaryFile(delete=True), and Windows doesn't allow reopening a file that's still held open by another handle.delete=Falseand close thewithblock before handing the path toPyMuPDFLoaderos.unlink()in afinallyblock, so behavior is unchanged on close/error pathsTest plan
PdfToEntries.extract_pdf_entriesdirectly againsttests/data/pdf/singlepage.pdfandtests/data/pdf/multipage.pdf— entry counts match whattests/test_pdf_to_entries.pyexpects (1 and 6 entries respectively)tempfile.gettempdir()before/after)