feat(bookmarks): support excluding tags with - prefix in search#684
Open
esefxdz wants to merge 2 commits into
Open
feat(bookmarks): support excluding tags with - prefix in search#684esefxdz wants to merge 2 commits into
esefxdz wants to merge 2 commits into
Conversation
Users can now prefix a tag with - in the bookmark search bar to exclude bookmarks containing that tag. For example, searching cat_ears -white_background shows bookmarks tagged cat_ears that are not also tagged white_background. Previously, the search only supported positive tag matching.
|
|
Excluded search terms now also check the bookmark source URL host, not just tags. Typing -danbooru excludes bookmarks from danbooru.donmai.us in addition to those tagged danbooru.
Owner
|
Thanks for the PR, this looks good but i want to keep this bookmark filter feature simple for now until I come up with a better design that scale better with more complex search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can now prefix a tag with - in the bookmark search bar to exclude bookmarks containing that tag. For example, searching cat_ears -white_background shows bookmarks tagged cat_ears that are not also tagged white_background. Previously, the search only supported positive tag matching.