Skip to content

Footer - #131

Merged
khannakshat7 merged 6 commits into
khannakshat7:UI-tempfrom
shonali2600:footer
May 29, 2021
Merged

Footer#131
khannakshat7 merged 6 commits into
khannakshat7:UI-tempfrom
shonali2600:footer

Conversation

@shonali2600

Copy link
Copy Markdown
Contributor

Related Issuse

Footer was not looking different from the whole page

Closes: #101

Describe the changes you've made

I've designed the footer, changed the background colour and some of the text colour.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Screenshots

| Original |
footer1

| Updated |
footer2

@shonali2600

Copy link
Copy Markdown
Contributor Author

@khannakshat7 sir, @CodesbyUnnati ma'am, kindly review my PR and provide me feedback, it's been 7 days now.

@CodesbyUnnati

Copy link
Copy Markdown
Collaborator

image
This PR is having conflicts shonali...Pls resolve them:)
image
Also, Please maintain the color scheme of the website for the footer.

@shonali2600

Copy link
Copy Markdown
Contributor Author

@CodesbyUnnati I've resolved the conflicts, and tried to change its color, but wasn't able to because of the "Elektra" Logo on the left side. I tried to use the blue color(same as Elektra logo) because it matches the theme, but the logo is not visible in that.
So can you please suggest me any better color?

@shonali2600

Copy link
Copy Markdown
Contributor Author

@CodesbyUnnati @khannakshat7 Please suggest me changes so that I can work on it and able to make PR. Also my other PR are also pending since long #132 and #158 , Please review that also.

@khannakshat7

Copy link
Copy Markdown
Owner

@shonali2600 can you pl. resolve the conflicts

@shonali2600

Copy link
Copy Markdown
Contributor Author

@khannakshat7 resolved the conflicts

@khannakshat7

Copy link
Copy Markdown
Owner

@shonali2600 Please don't use the beautifier and don't commit settings.py file as it has ur DB credentials

@shonali2600

Copy link
Copy Markdown
Contributor Author

@khannakshat7 I've reverted the commit, now it's fine

@shonali2600 shonali2600 reopened this May 21, 2021
@khannakshat7

Copy link
Copy Markdown
Owner

@shonali2600 It is perfect but can u pl. remove the extra space below footer.
image

@shonali2600

Copy link
Copy Markdown
Contributor Author

elek

@khannakshat7 done

@khannakshat7 khannakshat7 added gssoc21 GSSOC 21 Level3 enhancement New feature or request labels May 29, 2021
@khannakshat7
khannakshat7 changed the base branch from master to UI-temp May 29, 2021 09:39
@khannakshat7
khannakshat7 merged commit 8d66ecb into khannakshat7:UI-temp May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gssoc21 GSSOC 21 Level3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GSOOC'21] Making footer look different from the home page.

3 participants