feat: add authentication and role guard to scoring SSE stream endpoint - #2
Merged
Merged
Conversation
Add requireAuth middleware and requireScorer role guard to the scoring SSE stream endpoint (GET /:eventCode/scoring/stream). The requireScorer guard allows ADMIN, TSO, HEAD_REFEREE, and REFEREE roles, consistent with the pattern used by the inspection stream. Co-Authored-By: Thành Trần <thanhkt27507@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
requireAuthmiddleware and a newrequireScorerrole guard to the scoring SSE stream endpoint (GET /:eventCode/scoring/stream).Previously this endpoint had no authentication or authorization, unlike the inspection stream which uses
requireAuth+requireInspector.Changes:
guards.ts: AddedrequireScorerguard allowingADMIN,TSO,HEAD_REFEREE, andREFEREEroles (the roles involved in scoring operations).scoring.routes.ts: AppliedrequireAuthmiddleware andrequireScorerviagetEventCodeWithGuard(), matching the pattern used by the inspection stream.Review & Testing Checklist for Human
ADMIN,TSO,HEAD_REFEREE,REFEREE) cover all users who need scoring stream access in your deploymentuseScoringRealtime(eventCode, token)and will need a token with one of the allowed roles/api/events/:eventCode/scoring/streamreturn 401Notes
/:eventCode/display/stream) and match-control stream endpoint (/:eventCode/match-control/stream) also lack auth — these may need similar treatment depending on your requirements.Link to Devin session: https://app.devin.ai/sessions/2f3a878b48254d9c906c9c6100fefc13
Requested by: @khanhthanhdev