Skip to content

Maintenance WP3: add API reference pages for sensory, simulation, and the tooling layer#453

Open
kgdunn wants to merge 4 commits into
mainfrom
claude/process-improve-maintenance-review-0lbiru-wp3
Open

Maintenance WP3: add API reference pages for sensory, simulation, and the tooling layer#453
kgdunn wants to merge 4 commits into
mainfrom
claude/process-improve-maintenance-review-0lbiru-wp3

Conversation

@kgdunn

@kgdunn kgdunn commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Summary

Implements work package 3 of the 2026-07-10 maintenance review (#450). Independent of WP1 (#451) and WP2 (#452); the last of the three to merge may need a trivial version-line rebase.

  • Adds docs/api/sensory.rst, docs/api/simulation.rst, and docs/api/tooling.rst (recipes, tool_spec, config, tool_safety, mcp_server), wired into the API toctree. These modules previously had no reference documentation at all; the per-package tools.py MCP wrappers stay out, matching the existing pages.
  • Uses :members: without :undoc-members: on the new pages: the sensory/tooling result classes document their fields in napoleon Attributes sections, and :undoc-members: duplicated those objects, failing the strict -W build with 35 warnings.
  • Also carries the macOS CBC-solver skip for test_more_restarts_is_never_worse (cherry-picked to every open branch) so the flaky Rosetta-emulated solver does not fail this PR's test matrix.

Test plan

  • sphinx-build docs docs/_build/html -b html -W passes locally (zero warnings; notebooks executed)
  • New pages render with populated member listings (sensory: 40 objects, simulation: 9, tooling: 61)
  • All 13 newly documented modules import cleanly for autodoc (including mcp_server with the mcp extra installed)
  • Docs workflow green on this PR

Checklist

  • Version bumped in pyproject.toml (PATCH for fixes/docs/config, MINOR for new features): 1.52.5, CITATION.cff synced
  • Tests added or updated where relevant (n/a: docs-only, plus one test-skip marker)
  • ruff check . passes
  • CHANGELOG.md updated (deliberately skipped: owner opted for no changelog entry for this internal-only batch)

🤖 Generated with Claude Code

https://claude.ai/code/session_01CynhA39u8mQeFWR3Ccf2UJ


Generated by Claude Code

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

claude added 4 commits July 11, 2026 05:45
#450)

The API reference documented eight subpackages but omitted the two
newest (sensory, simulation) and the recipes/tool_spec/config/
tool_safety/mcp_server layer entirely; those modules were only described
narratively in architecture.rst. Add three pages following the existing
automodule conventions and wire them into the api/index.rst toctree.
The per-package tools.py MCP wrappers stay out of the reference,
matching the existing pages.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CynhA39u8mQeFWR3Ccf2UJ
…nings (#450)

The sensory/tooling result classes document their fields in napoleon
Attributes sections; :undoc-members: made autodoc emit the same
annotated fields a second time, producing 35 duplicate-object warnings
that fail the strict (-W) build. With :members: alone the docstring
documentation wins and the build is warning-clean. Pages render with
populated listings (40/9/61 documented objects).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CynhA39u8mQeFWR3Ccf2UJ
PATCH bump for the docs API-reference work; CITATION.cff synced in the
same commit. Assumes WP1 (#451) and WP2 (#452) merge first as 1.52.3
and 1.52.4; if merge order differs the number still moves forward. No
changelog entry: owner classed this batch as internal-only.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CynhA39u8mQeFWR3Ccf2UJ
The docs CI build failed: autodoc could not import
process_improve.mcp_server because the mcp package's pydantic models
raise PydanticSchemaGenerationError under sphinx's reload-based
importer (mcp 1.28.1 with pydantic 2.13.4; a direct import of the same
module in the same environment succeeds). Reproduced locally on a clean
full build. Mock mcp via autodoc_mock_imports so api/tooling documents
mcp_server's own docstrings without importing the real FastMCP.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CynhA39u8mQeFWR3Ccf2UJ
@kgdunn
kgdunn force-pushed the claude/process-improve-maintenance-review-0lbiru-wp3 branch from 897cf75 to bc7f248 Compare July 11, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants