fix(jwt): resolveAuthContext must load app models before constant()#86
Merged
Conversation
When an Application defines a custom user_model (e.g. user_model='User'), JwtEndpoint::resolveAuthContext called constant($app->user_model) to resolve the model definition. App-scoped constants are registered by Api::loadAppModels() during the normal MVC pipeline — but JwtEndpoint dispatches *before* that pipeline runs (login can't require auth). Result: PHP 8 fatal "Undefined constant 'User'" → HTTP 500 from /jwt/login on every app with a custom user_model. HMAC /Session login didn't hit this because Api::route() walks through loadAppModels() before reaching the session controller. The JWT endpoint deliberately bypasses that path, creating the gap. Fix: call Api::loadAppModels($app) right after retrieving the app row and before referencing the constant. Defensive fallback: if the constant still isn't defined after loading (e.g. user_model references a name that no DataModel row defines), fall back to KyteUser with an error_log breadcrumb. Login then fails at password_verify rather than fataling — safer client-facing surface. All 12 JwtEndpointTest tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
`resolveAuthContext` calls `Api::loadAppModels($app)` immediately after retrieving the app row. Defensive fallback to KyteUser if the constant still isn't defined.
Test plan
Patch v4.4.3. No schema changes.
🤖 Generated with Claude Code