feat: anonymous fall-through for JWT-mode public access (KYTE-#229)#37
Merged
Merged
Conversation
When a JWT-mode client has no access token AND no refresh token (a visitor who never logged in), _jwtEnsureFreshAccessToken now issues the request anonymously (x-kyte-appid only, no Authorization header) instead of failing closed. This enables public/anonymous browsing of requireAuth=false controllers served by the server's new AppContextStrategy. A present-but-stale access token with no refresh token still fails so the caller destroys state + bounces to login (unchanged). issueRequest already omits the Authorization header when no token is present and always sends x-kyte-appid, so the anonymous request shape was already supported — it was just unreachable. Pairs with kyte-php v4.11.0 (KYTE-#229).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client half of #229. When a JWT-mode client has no access token AND no refresh token (never logged in),
_jwtEnsureFreshAccessTokennow issues the request anonymously (x-kyte-appid only) instead of failing closed — enabling public browsing of requireAuth=false controllers via the server's AppContextStrategy. Present-but-stale token w/ no refresh still fails to login (unchanged). Pairs with kyte-php v4.11.0.🤖 Generated with Claude Code