Bug fixes : SSE import completion, SQL comment parsing, and UI improvements - #40
Merged
Conversation
…ntic paths (/import, /preview, /history)
…ry key on target table, not application bug
…f redirecting to error page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--comment handling in SqlParser that was breaking certain dump filesChanges
SSE Import Success Display
Previously, when an SSE import completed successfully,
location.reload()redirected to/importwhich showed "No filename specified" error because the session was already cleared.Now displays a styled success message in-page with:
SQL Parser Fix
Fixed edge case where
--inside string literals was incorrectly treated as a comment delimiter.UI Fix
Corrected vertical alignment of the preview button to match other action buttons in the file list.