Propagate Pythia8 generator weight vector to EDM4hep - #158
Conversation
|
Confirmed That means this PR subsumes #148. |
|
Do you want this in the upcoming release @selvaggi? |
Yes, please. |
|
@jmcarcell @kjvbrt anything else before this can be merged? |
tmadlener
left a comment
There was a problem hiding this comment.
This looks good to me. I suppose the weight names follow from the pythia cmd file somehow? In light of @kjvbrt comment that this also includes the LHEF weights, I think it would be a good idea to also add a test related to that (potentially in a follow up PR).
I have rebased onto the current main branch and resolved a minor conflict along the way.
|
@tmadlener yes the names come from |
Use get_reader to allow rntuples Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
DelphesPythia8_EDM4HEPcurrently stores only the nominal event weight.This PR implements storing the full
pythia.infoweight vector inEventHeader.weightsandand the weight labels in the metadata under
edm4hep::labels::EventWeightsNames.examples/data/ee_Z_bbbar_ecm91GeV_weights.cmdis an example card with the weight machinery enabled.