Skip to content

Remove deprecated Cluster phi aliases #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmcarcell wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −14
Open

Remove deprecated Cluster phi aliases #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e1a149
Remove deprecated Cluster phi aliases
jmcarcell Sep 5, 2026
366943f
Update README schema links
jmcarcell Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,30 +26,30 @@ A generic event data model for future HEP collider experiments.
| [EventHeader](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L229) | [MCParticle](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L241) | [SimTrackerHit](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L313) |
| [CaloHitContribution](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L349) | [SimCalorimeterHit](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L362) | [RawCalorimeterHit](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L373) |
| [CalorimeterHit](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L382) | [ParticleID](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L393) | [Cluster](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L407) |
| [TrackerHit3D](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L444) | [TrackerHitPlane](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L469) | [SenseWireHit](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L510) |
| [RawTimeSeries](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L497) | [Track](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L534) | [Vertex](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L577) |
| [ReconstructedParticle](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L623) | [TimeSeries](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L657) | [RecDqdx](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L669) |
| [TrackerHit3D](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L438) | [TrackerHitPlane](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L463) | [SenseWireHit](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L504) |
| [RawTimeSeries](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L491) | [Track](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L528) | [Vertex](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L571) |
| [ReconstructedParticle](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L617) | [TimeSeries](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L651) | [RecDqdx](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L663) |

**Links**

| | | |
|-|-|-|
| [RecoMCParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L711) | [CaloHitSimCaloHitLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L735) | [TrackerHitSimTrackerHitLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L741) |
| [CaloHitMCParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L717) | [ClusterMCParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L723) | [TrackMCParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L729) |
| [VertexRecoParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L747) | | |
| [RecoMCParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L705) | [CaloHitSimCaloHitLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L729) | [TrackerHitSimTrackerHitLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L735) |
| [CaloHitMCParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L711) | [ClusterMCParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L717) | [TrackMCParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L723) |
| [VertexRecoParticleLink](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L741) | | |

**Generator related (meta-)data**

| | | |
|-|-|-|
| [GeneratorEventParameters](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L678) | | |
| [GeneratorEventParameters](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L672) | | |
| | | |

**Interfaces**

| | | |
|-|-|-|
| [TrackerHit](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L694) | | |
| [TrackerHit](https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L688) | | |

The tests and examples in the `tests` directory show how to read, write, and use these types in your code.

Expand Down
6 changes: 0 additions & 6 deletions edm4hep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,18 +427,12 @@ datatypes:
declaration: |
/// Get the position error value for the two passed dimensions
float getPositionError(edm4hep::Cartesian dimI, edm4hep::Cartesian dimJ) const { return getPositionError().getValue(dimI, dimJ); }
/// Get the Azimuthal angle of the cluster's intrinsic direction (used e.g. for vertexing). Not to be confused with the cluster position seen from IP
[[deprecated("Use getIPhi instead")]]
float getPhi() const { return getIPhi(); }

MutableExtraCode:
includes: "#include <edm4hep/Constants.h>"
declaration: |
/// Set the position error value for the two passed dimensions
void setPositionError(float value, edm4hep::Cartesian dimI, edm4hep::Cartesian dimJ) { return getPositionError().setValue(value, dimI, dimJ); }
/// Set the Azimuthal angle of the cluster's intrinsic direction (used e.g. for vertexing). Not to be confused with the cluster position seen from IP
[[deprecated("Use setIPhi instead")]]
void setPhi(float value) { setIPhi(value); }


edm4hep::TrackerHit3D:
Expand Down
Loading