Harden upscaler CLI and add test coverage - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.tiffiles, EXIF orientation, and JPEG color modes--yesfor automation and return nonzero status for processing failuresWhy
The audit reproduced a path traversal issue in custom naming, zero-dimension failures for tiny images, and avoidable installation weight from unused dependencies. The CLI also lacked automated regression coverage and reliable exit codes for scripted use.
Impact
PixelNova is safer for custom naming, more reliable across supported image formats and edge cases, lighter to install, and easier to automate and maintain.
Validation
python3 -m unittest discover -v— 8 tests passpython3 -m compileall -q upscaler.py demo.py example.py setup.py testsbash -n run.shgit diff --check