Add Perl + MongoDB Quickstart (Addressed review feedback)#851
Add Perl + MongoDB Quickstart (Addressed review feedback)#851Akshat005Chaudhary wants to merge 4 commits into
Conversation
|
Hi @amaan-bhati , resubmitting this PR after addressing all previous review comments (Ref: #774). Would appreciate another look. |
amaan-bhati
left a comment
There was a problem hiding this comment.
Thanks for resubmitting and addressing the previous feedback given on #774. A few things still need to be fixed that i've segregated into blocking, should fix and nit picks:
Blocking
-
Sidebar duplication (
versioned_sidebars/version-4.0.0-sidebars.json): The diff accidentally introduces duplicateCI/CD Integrationentries (now appears 3x) and a duplicateTest Coverage Integration. There's also aK8s Proxycategory added here that has nothing to do with this PR - looks like a bad conflict resolution during rebase. Please clean this up; it'll break the v4.0.0 sidebar. -
Missing unversioned doc: The guide is only added under
versioned_docs/version-4.0.0/. The links inQuickStartList.jspoint to/docs/quickstart/perl-mongo/which resolves to the current/unversioned docs - that file doesn't exist, so the filter cards will 404. You need adocs/quickstart/perl-mongo.mdas well. -
Sample app in personal repo: Both clone commands point to your personal GitHub account. All other quickstarts use
github.com/keploy/.... Once you are 100% sure on self review on your personal repo, let me know, i'll tell you where exactly to create a pr to add the sample app.
Should fix
-
The anchor links in
QuickStartList.jsdon't match the actual heading slugs. E.g. the Docker heading is## How to run the sample application Using Docker Compose 🐳but the link uses#running-app-using-docker-compose-. Double-check both anchors. -
Local
keploy testcommand is missing--delay- the Docker version has it (--delay 10). Add it for consistency. -
Heading levels in the local section are inconsistent - subsections jump to
##where the Docker section uses###. Keep them###.
Nits
- "Keploy with capture" → "will capture" (appears twice)
shortUrl: "http://localhost:5000QWERTY"is missing a/- should behttp://localhost:5000/QWERTY- Image alt text is literally
alt textin both places - make it descriptive, helps in seo and image failure as well.
Summary
This PR re-submits the Perl + MongoDB Quickstart after addressing feedback from the previous review.
Ref: #774
Updates Based on Review
keploy recordandkeploy testusage for both Docker and local setups are clearly documented for the ease of beginners, with explicit references to sections being attacked below.Keploy Record in local setup

Keploy Test in local setup

Keploy Record in Docker setup

Keploy Test in Docker setup

Notes
All feedback from the previous review has been addressed.
Happy to make further improvements if needed.