Request for comment: Remove react palm task middleware requirement - #1583
Draft
chrisirhc wants to merge 2 commits into
Draft
Request for comment: Remove react palm task middleware requirement#1583chrisirhc wants to merge 2 commits into
chrisirhc wants to merge 2 commits into
Conversation
Signed-off-by: Chris Chua <chris.sirhc@gmail.com>
Signed-off-by: Chris Chua <chris.sirhc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's another attempt at simplifying the react-palm tasks dependency, after discussion in #1577 .
First off, to pull out the middleware requirement of react-palm.
This should simplify installation of kepler.gl . This approach combined with #1577 are approaches to allow for future splitting out side effects/tasks into its own components in the future.
It is safe to run the taskMiddleware twice (if the middleware is added, along with this change), so this is a non-breaking change. That's also why I left
enhanceReduxMiddlewarein the exports, but now that's a noop.What users should expect to do:
enhanceReduxMiddleware(which is now a noop)enhanceReduxMiddlewarecan be removed.