Simplify daemonset volumes#5
Conversation
Move them to daemonset file, and remove options that cannot work
There was a problem hiding this comment.
Pull request overview
This PR refactors the DaemonSet volume configuration by moving it from a shared helper template directly into the daemonset.yaml file, and removes volume types (PVC and Secret) that are incompatible with DaemonSet workloads.
Changes:
- Moved volume configuration for DaemonSets from the
kagent.podVolumeshelper template into daemonset.yaml - Removed support for PVC and Secret volume types for DaemonSets (only hostPath and emptyDir are now supported)
- Deleted the now-unused
kagent.podVolumeshelper template from _helpers.tpl
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/daemonset.yaml | Added inline volume configuration supporting hostPath and emptyDir for both data and keypair volumes |
| templates/_helpers.tpl | Removed the kagent.podVolumes helper template and its invocation from kagent.podSpec, as volumes are now configured directly in daemonset.yaml |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| volumes: | ||
| {{- if .Values.persistence.enabled }} | ||
| {{- if eq .Values.persistence.type "hostPath" }} | ||
| - name: data | ||
| hostPath: | ||
| path: {{ .Values.persistence.hostPath.path }} |
There was a problem hiding this comment.
The new DaemonSet volumes rendering logic is not covered by the existing Helm unit tests (current tests/daemonset_test.yaml focuses on probes/env). Please add assertions that validate the rendered spec.template.spec.volumes entries for both persistence.type (hostPath vs emptyDir) and keypair volume behavior, so regressions in volume naming/types are caught.
Move them to daemonset file, and remove options that cannot work