Conversation
- packages/three/src/index.ts: replace `export * from ./quadtree` / `./tasks`
with explicit named exports; drop leaked LOD internals (update, createState,
beginUpdate, allocLeafSet, resetLeafSet, allocSeamTable, resetSeamTable,
buildSeams2to1, SeamTable, buildLeafIndex, createSpatialIndex, U32_EMPTY,
runTileBoundsReduction)
- remove dead NodeFlags / isLive / NodeStore.flags / NodeStore.roots
- rename tsl/heightmap.ts -> tsl/elevationTexture.ts: ElevationTexture,
sampleElevationTextureMeters (deprecated aliases kept for one release)
- rename createTerrainFieldTextureTask -> createTerrainFieldStorageTask
(deprecated alias kept); terrainTasks keys createTileNodes -> tileNodes,
createTerrainFieldTexture -> createTerrainFieldStorage
- createComputePipelineTasks(leaf, { name }) derives
${name}CompileTask / ${name}ExecuteTask display names
- elevationFn.displayName("elevationFn"); fix stale terrainFieldStageTask doc
- "sideEffects": false on three / react / work
- docs: changelog entry, elevation-texture + custom compute stage sections,
spec updates; bean hello-terrain-b5k2 completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@hello-terrain/threere-exported the wholequadtree/andtasks/barrels, leaking the LOD driver internals; a few names still usedheightmapwhere the spec sayselevation.index.tsnow uses explicit named exports. Removed from the public surface:update,createState,beginUpdate,allocLeafSet,resetLeafSet,allocSeamTable,resetSeamTable,buildSeams2to1,SeamTable,buildLeafIndex,createSpatialIndex,U32_EMPTY,runTileBoundsReduction. The topology contract, factories, task refs, and graph data types stay public.NodeFlags,isLive,NodeStore.flags,NodeStore.roots;createNodeStore(maxNodes)no longer takesspaceCount.@deprecatedaliases:sampleHeightmapMeters→sampleElevationTextureMeters,HeightmapTexture→ElevationTexture(moduletsl/heightmap.ts→tsl/elevationTexture.ts),createTerrainFieldTextureTask→createTerrainFieldStorageTask.terrainTasks.createTerrainFieldTexture→createTerrainFieldStorage,terrainTasks.createTileNodes→tileNodes.createComputePipelineTasks(leaf, { name })derives${name}CompileTask/${name}ExecuteTaskso custom pipelines don't collide with the defaults ingraph.inspect(); test added.elevationFn.displayName("elevationFn"); stalepackHalf2x16doc onterrainFieldStageTaskrewritten for the RGBA pack."sideEffects": falseon three/react/work (audited for import-time side effects; none required). CJS build left as is.createComputePipelineTasksdocs, changelog; specsarchitecture.md,naming-conventions.md,terrain-data-model.mdupdated; docs components updated to new names.Verification
pnpm -r buildsucceeds and three's dist export list no longer contains the removed symbols.TerrainTaskstype vs keys,sideEffectssafety, alias correctness): no findings. Grep acrosspackages/react,apps/docs, READMEs finds no stale references.Merge notes
nodeStore.ts:flagsremoval vsallocNodeRaw) and docs: align README/docs with the real API #25 (both add a compute-stages section toelevation-function.mdx; keep docs: align README/docs with the real API #25's version of the example, which builds the graph without the default compute tasks). Changelog "Unreleased" overlaps with all open PRs.hello-terrain-b5k2.Made with Cursor