Phase 3: strict summary() defaults + deterministic tie-break - #9
Open
mewincaka wants to merge 1 commit into
Open
Phase 3: strict summary() defaults + deterministic tie-break#9mewincaka wants to merge 1 commit into
mewincaka wants to merge 1 commit into
Conversation
…ie-break - Change top_k default from 5 to 3 per spec - Remove auto-inference of columns (conservative defaults): if no column lists specified, summary() returns only n per group - Add deterministic categorical tie-breaking: count desc, then string(value) asc - Rewrite tests/test_summary.py with full coverage: by/no-by, default-only-n, date coercion, numeric quartiles, categorical tie-breaking, wide output, missingness - Update README with conservative-defaults examples Fixes kengggg#8 Plan ID: d4ff330f Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
Collaborator
Author
|
CI is green ✅ — ready for review: #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Plan ID: d4ff330f
Summary
summary()no longer auto-infers columns. Ifdate_cols,numeric_cols, andcategorical_colsare all omitted, it returns onlynper group.top_kdefault: Changed from 5 to 3 per spec.string(value)ascending.tests/test_summary.pywith 22 tests covering: by/no-by, default-only-n, date coercion, numeric quartiles, categorical tie-breaking, wide output, missingness.Local checks
Test plan
byvs no-bygroupingnbehavior (conservative defaults)<NA>token)🤖 Generated with Claude Code