Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@ jobs:
- name: Tests
run: |
pytest

- name: Quick import smoke test
run: |
python -c "import epydem; print('epydem imported')"
84 changes: 0 additions & 84 deletions .github/workflows/test.yml

This file was deleted.

29 changes: 29 additions & 0 deletions PR_ACTIONS_FIX.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
GitHub Actions fix: CI was failing on Python 3.9 because epydem now requires Python >= 3.10 (pyproject.toml).

Changes
- Consolidate CI by removing redundant `.github/workflows/test.yml` (keep `ci.yml` as the single CI).
- Ensure CI only tests supported Python versions (>=3.10).
- Install via `pip install -e '.[dev]'` (single source of truth).
- Add a quick import smoke test to CI.

Why this implementation
- Running CI on unsupported Python versions creates noisy failures and slows iteration.
- Keeping workflows consistent reduces maintenance and confusion.

Multi-role debate (differences, not consensus)

Role A — pragmatic developer
- 👍 Likes: CI goes green and matches supported versions; simpler workflow.
- ⚠️ Concern: removes older-Python signal; but we explicitly don’t support <3.10.

Role B — architecture
- 👍 Likes: single tooling stack (ruff) and consistent install path.
- ⚠️ Concern: having both `ci.yml` and `test.yml` is redundant; consider consolidating later.

Role C — developer user (DX)
- 👍 Likes: less CI noise; clearer support policy.
- ⚠️ Concern: if users want older Python, they’ll need a documented support decision.

Points of divergence to revisit later
1) Consolidate workflows (keep one CI file).
2) Add `python-version: 3.13` when ready.
Loading