Skip to content

docs(runbook): fix wrong upstream citation in kanidm-oauth2-client-drift#144

Merged
kelchm merged 1 commit into
mainfrom
chore/kaniop-runbook-citation-fix
Jun 23, 2026
Merged

docs(runbook): fix wrong upstream citation in kanidm-oauth2-client-drift#144
kelchm merged 1 commit into
mainfrom
chore/kaniop-runbook-citation-fix

Conversation

@kelchm

@kelchm kelchm commented Jun 20, 2026

Copy link
Copy Markdown
Owner

The basic_secret-drift runbook cited pando85/kaniop#491 as the upstream tracker, but #491 is "Add webhook caching for Kanidm objects" — unrelated to the OAuth2 secret race.

Upstream search (kaniop + kanidm, open+closed issues/PRs/discussions) confirmed the multi-replica basic_secret read-after-write race is not tracked upstream. Fixed the citation to reference #648 (the force-secret-rotation annotation the runbook recovery relies on) and the kanidm replication eventual-consistency docs.

A file-ready upstream issue for the race itself has been drafted separately (pending a decision to file).

🤖 Generated with Claude Code

The basic_secret-drift runbook cited pando85/kaniop#491 as the upstream
tracker, but #491 is "Add webhook caching for Kanidm objects" (unrelated).
The multi-replica basic_secret read-after-write race is not tracked
upstream; cite #648 (the force-secret-rotation annotation we rely on) and
the kanidm replication eventual-consistency docs instead.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 20, 2026 04:53
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kelchm, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 18 minutes and 17 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 44067911-b467-4af1-addf-edb50f0979e6

📥 Commits

Reviewing files that changed from the base of the PR and between 2c1488c and 39ea1de.

📒 Files selected for processing (1)
  • docs/runbooks/kanidm-oauth2-client-drift.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/kaniop-runbook-citation-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Kanidm OAuth2 client drift recovery runbook to correct an incorrect upstream reference and better ground the recovery guidance in the actual upstream change and kanidm’s replication model.

Changes:

  • Replaced the unrelated upstream issue link (pando85/kaniop#491) with the relevant upstream PR adding force-secret-rotation (pando85/kaniop#648).
  • Clarified that the underlying multi-replica basic_secret read-after-write race is not currently tracked upstream, and pointed readers to kanidm’s eventual-consistency replication documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kelchm
kelchm merged commit a16c807 into main Jun 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants