docs(runbook): fix wrong upstream citation in kanidm-oauth2-client-drift#144
Conversation
The basic_secret-drift runbook cited pando85/kaniop#491 as the upstream tracker, but #491 is "Add webhook caching for Kanidm objects" (unrelated). The multi-replica basic_secret read-after-write race is not tracked upstream; cite #648 (the force-secret-rotation annotation we rely on) and the kanidm replication eventual-consistency docs instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 18 minutes and 17 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the Kanidm OAuth2 client drift recovery runbook to correct an incorrect upstream reference and better ground the recovery guidance in the actual upstream change and kanidm’s replication model.
Changes:
- Replaced the unrelated upstream issue link (
pando85/kaniop#491) with the relevant upstream PR addingforce-secret-rotation(pando85/kaniop#648). - Clarified that the underlying multi-replica
basic_secretread-after-write race is not currently tracked upstream, and pointed readers to kanidm’s eventual-consistency replication documentation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The basic_secret-drift runbook cited pando85/kaniop#491 as the upstream tracker, but #491 is "Add webhook caching for Kanidm objects" — unrelated to the OAuth2 secret race.
Upstream search (kaniop + kanidm, open+closed issues/PRs/discussions) confirmed the multi-replica
basic_secretread-after-write race is not tracked upstream. Fixed the citation to reference #648 (theforce-secret-rotationannotation the runbook recovery relies on) and the kanidm replication eventual-consistency docs.A file-ready upstream issue for the race itself has been drafted separately (pending a decision to file).
🤖 Generated with Claude Code