fix: change monaco-editor imports to type-only imports#6578
Open
Federicorao wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6545.
Change monaco-editor imports to type-only imports in MonacoCELEditor validation and completions files to prevent SSR crash. The error 'window is not defined' occurs because monaco-editor module accesses window during initialization. Two files in the MonacoCELEditor directory import from monaco-editor at module level but only use types. Changing these to type-only imports prevents the module from being loaded on the server side, fixing the SSR issue.
I ran the available lightweight check for the frontend change.