feat: issue #5674- improve wf parsing#6559
Open
srivatsa-av28 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5674
📑 Description
Added an in-process parse cache to
WorkflowStorekeyed on(tenant_id, workflow_id), using the workflow's existingrevisionfield as the cache validity key.
Workflowobject directly,skipping
cyaml.safe_load()andParser.parse()entirelyinvalidate_workflow_cache()is called fromdelete_workflow()to evict stale entries on deletionthreading.Lockprotects the cache dict(safe for the
ThreadPoolExecutorused inWorkflowScheduler)Changes
keep/workflowmanager/workflowstore.py_CachedWorkflowdataclass to hold parsed workflow + revision_parse_cachedict and_cache_lockto__init__get_workflow()to check cache before parsinginvalidate_workflow_cache()methodinvalidate_workflow_cache()fromdelete_workflow()Notes
revisionis already incremented byadd_or_update_workflow()onevery update, making it a reliable and zero-cost cache key
✅ Checks
ℹ Additional Information