Format datetime fields with time and timezone information when present - #367
Merged
Conversation
Wigny
marked this pull request as draft
October 27, 2025 22:22
Wigny
force-pushed
the
format-datetime
branch
from
October 27, 2025 22:47
8806ac9 to
0279656
Compare
Wigny
marked this pull request as ready for review
October 27, 2025 22:57
Wigny
force-pushed
the
format-datetime
branch
from
October 27, 2025 23:01
0279656 to
e5bc819
Compare
Wigny
commented
Oct 27, 2025
Wigny
force-pushed
the
format-datetime
branch
from
October 27, 2025 23:47
e5bc819 to
b16feda
Compare
Wigny
force-pushed
the
format-datetime
branch
from
October 28, 2025 12:28
b16feda to
b2a36c3
Compare
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the time and timezone information for datetime fields is included in the OFX when present, accordingly to the spec.
It hides time and timezone when they are missing for fields that were previously rendered as dates (e.g.,
DTPOSTED), but keeps rendering time for fields that were already rendered with it (e.g.,DTSERVER) to avoid breaking changes.