Consolidate TRNTYPE lists - #364
Merged
Merged
Conversation
The acceptable values for `<STMTTRN><TRNTYPE>` are the same regardless of whether it is a child of `<BANKTRANLIST>` or `<INVBANKTRAN>`. See section 11.4.4 of the [OFX spec v2.3](https://financialdataexchange.org/common/Uploaded%20files/OFX%20files/OFX%20Banking%20Specification%20v2.3.pdf). There is no reason to have two separate lists (one of which was incomplete), so just use one.
edwagner
added a commit
to edwagner/ofxstatement-schwab-json
that referenced
this pull request
Oct 5, 2025
A [PR](kedder/ofxstatement#364) has been submitted to ofxstatement to add the necessary trntype, so in the meantime use the branch with the fix. Once the PR is merged, this change to the Pipfile should be reverted.
Owner
|
Sorry, missed this one somehow. Merging! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acceptable values for
<STMTTRN><TRNTYPE>are the same regardless of whether it is a child of<BANKTRANLIST>or<INVBANKTRAN>.See section 11.4.4 of the OFX spec v2.3.
There is no reason to have two separate lists (one of which was incomplete), so just use one.