fix: list conclusions workspace-wide instead of hard-coded "honcho" observer - #4
Open
geertvanzoest wants to merge 1 commit into
Open
Conversation
…erver (kechengzhang28#2) The Conclusions tab filtered on observer_id/observed_id "honcho", which matches nothing on Honcho servers that store conclusions under the observing peer itself, leaving the tab permanently empty. It also created an empty "honcho" peer as a side effect of the SDK's get-or-create peer() call. List and delete now go through the raw workspace-level conclusions API without an observer filter; the existing client-side observed-peer filter keeps working. Semantic search takes an explicit observer/observed scope, as required by the server. Fixes kechengzhang28#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Problem
src/features/conclusions/hooks.tshard-codedobserverId = "honcho"and listed conclusions throughhoncho.peer("honcho").conclusions, sending{"filters":{"observer_id":"honcho","observed_id":"honcho"}}. On Honcho servers where the deriver stores conclusions under the observing peer itself (e.g.observer_id: "alice"), that filter never matches, so the Conclusions tab is permanently empty. The SDK'speer()get-or-create also silently created an emptyhonchopeer in the workspace just by opening the tab.Changes
useConclusionListnow calls the workspace-levelPOST /v3/workspaces/{wid}/conclusions/listwith an empty filter, so conclusions from every observer show up; the existing client-side observed-peer dropdown keeps working (it now actually gets populated).useDeleteConclusiongoes straight toDELETE /v3/workspaces/{wid}/conclusions/{id}(no observer scope needed) — this also removes the peer-creation side effect.useConclusionSearchtakes an explicitobserverId/observedId, since the server requires an observer/observed scope for semantic search ("observer and observed must be specified for semantic search").getBaseUrl()inlib/honcho.ts(same DEV/localStorage logicgetHonchoalready used) for the raw API calls.Testing
npm run checkandnpm run lintpass.Supersedes #3.