Fix crash when calling removeAll() on an in-memory LoggerStore#374
Open
denricklaborada wants to merge 1 commit into
Open
Fix crash when calling removeAll() on an in-memory LoggerStore#374denricklaborada wants to merge 1 commit into
denricklaborada wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #373.
Calling
removeAll()(e.g. tapping Remove Logs inConsoleView) on aLoggerStorecreated with the.inMemoryoption crashes the app:Cause
removeAll()→_removeAll()→deleteEntities(for:)executes anNSBatchDeleteRequest. Batch requests operate directly against the backing SQLite store, bypassing the managed object context — they are only supported onNSSQLiteStoreType, notNSInMemoryStoreType. Since.inMemoryconfigures the store asNSInMemoryStoreType(LoggerStore.makeContainer), Core Data has no handler for the batch command and throws.Fix
Split
deleteEntities(for:)into two paths:NSBatchDeleteRequest(unchanged).context.delete(_:), save, and merge the deletions into the view context.Verification
Ran the demo app on an iPhone 17 Pro simulator, wired to an in-memory
LoggerStore(matching the crashing setup), triggeringremoveAll()on a store populated with 20 messages:NSInternalInconsistencyException/Unknown command type <NSBatchDeleteRequest ...>crash.