fix: avoids modify buffer in telescope extension (#161) - #175
Open
Alex-duzhichao wants to merge 1 commit into
Open
fix: avoids modify buffer in telescope extension (#161)#175Alex-duzhichao wants to merge 1 commit into
Alex-duzhichao wants to merge 1 commit into
Conversation
`exec_lazygit_command` run cmd using `vim.schedule`, which will be scheduled
after `vim.fn.feedkeys('j')`. So the buffer is changed to be modified, and
then jobstart report a `requires unmodified buffer` error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exec_lazygit_commandrun cmd usingvim.schedule, which will be scheduled aftervim.fn.feedkeys('j'). So the buffer is changed to be modified, and then jobstart report arequires unmodified buffererror.