increase app pagination to 100 and support multiple pages - #20
Merged
Conversation
Owner
Author
|
Dogfooded sha-7efa74c build; no issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves an issue where OIDC clients beyond the default page limit were excluded from the dashboard.
Pocket ID's
GET /api/oidc/clientsendpoint paginates results by default with a limit of 20 items per page (pagination[limit]=20). Previously,PocketIDService.fetchApps()made an unparameterized request, causing any applications on subsequent pages (client #21+) to be silently dropped.This change updates
fetchApps()to:pagination[limit]=100) to minimize round-trip requests.pagination[page]andpagination.totalPagesuntil every client is retrieved.Fixes #21
Type of Change
How Has This Been Tested?
npm run checkChecklist:
Security Impact
Does this PR introduce any changes that affect the security of the application (authentication, data handling, etc.)?