Skip to content

increase app pagination to 100 and support multiple pages - #20

Merged
kc9wwh merged 1 commit into
mainfrom
fix/pagination
Aug 16, 2026
Merged

increase app pagination to 100 and support multiple pages#20
kc9wwh merged 1 commit into
mainfrom
fix/pagination

Conversation

@kc9wwh

@kc9wwh kc9wwh commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Description

Resolves an issue where OIDC clients beyond the default page limit were excluded from the dashboard.

Pocket ID's GET /api/oidc/clients endpoint paginates results by default with a limit of 20 items per page (pagination[limit]=20). Previously, PocketIDService.fetchApps() made an unparameterized request, causing any applications on subsequent pages (client #21+) to be silently dropped.

This change updates fetchApps() to:

  • Request 100 items per page (pagination[limit]=100) to minimize round-trip requests.
  • Loop through all result pages using pagination[page] and pagination.totalPages until every client is retrieved.
  • Add structured debug/info logging with app counts and names for easier troubleshooting.

Fixes #21

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual test: Verified that all configured applications across multiple pages (including newly added OIDC clients) are fetched and rendered properly in the dashboard. Inspected server logs to confirm multi-page retrieval and total app counts.
  • Automated test: npm run check

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Security Impact

Does this PR introduce any changes that affect the security of the application (authentication, data handling, etc.)?

  • No

@kc9wwh

kc9wwh commented Aug 16, 2026

Copy link
Copy Markdown
Owner Author

Dogfooded sha-7efa74c build; no issues.

@kc9wwh
kc9wwh merged commit 7fea9db into main Aug 16, 2026
4 checks passed
@kc9wwh
kc9wwh deleted the fix/pagination branch August 16, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Launcher only sees the first 20 apps

1 participant