Refactor dependencies in s-pipes-core, forms and model#428
Open
MSattrtand wants to merge 12 commits into
Open
Conversation
Collaborator
Author
|
I've updated the |
blcham
self-requested a review
September 4, 2025 08:58
blcham
requested changes
Sep 4, 2025
blcham
left a comment
blcham
left a comment
Contributor
There was a problem hiding this comment.
see my comments, after it is fixed i will do the review again
MSattrtand
force-pushed
the
332-fix-dependencies-in-core
branch
2 times, most recently
from
September 4, 2025 11:34
b3beee4 to
cbfc385
Compare
added 4 commits
September 12, 2025 13:50
MSattrtand
force-pushed
the
332-fix-dependencies-in-core
branch
from
September 12, 2025 11:59
cbfc385 to
14e142b
Compare
added 6 commits
September 13, 2025 12:58
blcham
force-pushed
the
332-fix-dependencies-in-core
branch
from
September 13, 2025 11:00
14e142b to
353fa80
Compare
Fixes error in tests: ``` SLF4J: No SLF4J providers were found. SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details. OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves partially #332